This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Allow updates to existing winget manifests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldennington
force-pushed
the
fix-hash
branch
2 times, most recently
from
9895f5a to
39179dc
Compare
We recently received notification from a customer that installing `microsoft/git` via winget was broken due to a signing issue. This happened because we accidentally deployed an incorrect SHA for the `microsoft/git` version `2.33.0.0.0` manifest on `microsoft/winget-pkgs` then replaced the asset on GitHub with a new version with a new SHA. When we tried to re-run the `update-winget` workflow to correct the SHA, we discovered some issues with the action that make it impossible to update existing manifests. This PR updates the action to allow us to both create new winget manifests and update existing ones. [Here](https://github.com/ldennington/winget-playground/pull/47) is an example of a test PR opened to update an existing manifest with these changes. And [here](https://github.com/ldennington/winget-playground/pull/48) is an example of a test PR that creates a new manifest with these changes.
ldennington
force-pushed
the
fix-hash
branch
from
39179dc to
2dec41f
Compare
|
I'm seeing some weirdness where compiling with |
mjcheetham
approved these changes
Sep 17, 2021
ldennington
added a commit
to ldennington/git
that referenced
this pull request
Sep 17, 2021
This version allows us to update existing `winget` manifests by specifying a manifest's SHA if it already exists in `microsoft/winget-pkgs`. Pull Requests --------------- * [microsoft#178](mjcheetham/update-winget#179): Allow updates to existing winget manifests
ldennington
added a commit
to git-ecosystem/git-credential-manager
that referenced
this pull request
Sep 17, 2021
This version allows us to update existing `winget` manifests by specifying a manifest's SHA if it already exists in `microsoft/winget-pkgs`. Pull Requests --------------- * [#178](mjcheetham/update-winget#179): Allow updatesto existing winget manifests
This was referenced Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently received notification from a customer that installing
microsoft/gitvia winget was broken due to a signing issue. This happenedbecause we accidentally deployed an incorrect SHA for the
microsoft/gitversion
2.33.0.0.0manifest onmicrosoft/winget-pkgsthen replacedthe asset on GitHub with a new version with a new SHA.
When we tried to re-run the
update-wingetworkflowto correct the SHA, we discovered some issues with the action that make it
impossible to update existing manifests. This PR updates the action to allow
us to both create new winget manifests and update existing ones.
Here is an example of a test PR opened to update an existing manifest with these changes.
And here is an example of a test PR that creates a new manifest with these changes.