Skip to content

Commit

Permalink
Disable Rails/PluckId cop by default
Browse files Browse the repository at this point in the history
This cop was originally disabled with the original rubocop import: standardrb@71e48d5#diff-da3213a24b350fa386ff3bab0d6b239112408c3fe4f986cbd9d5236f7e0b61e4R458-R463

It was subsequently enabled during a mass enable commit: standardrb@24bc50f#diff-da3213a24b350fa386ff3bab0d6b239112408c3fe4f986cbd9d5236f7e0b61e4R248-R249

As discussed on this issue, the cop is unsafe by default and frequently gets false positives: rubocop/rubocop-rails#301

It is disabled by default in most recent rubocop release, for same reasons: https://github.com/rubocop/rubocop-rails/blob/v2.25.0/config/default.yml#L746-L751

Discussion of why to disable on: standardrb#31
  • Loading branch information
mjankowski committed May 24, 2024
1 parent c4dee91 commit 352895f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config/base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ Rails/Pluck:
Enabled: true

Rails/PluckId:
Enabled: true
Enabled: false

Rails/PluckInWhere:
Enabled: true
Expand Down

0 comments on commit 352895f

Please sign in to comment.