Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editing interface #8

Merged
merged 55 commits into from
Apr 22, 2022
Merged

Add editing interface #8

merged 55 commits into from
Apr 22, 2022

Conversation

mjakeman
Copy link
Owner

@mjakeman mjakeman commented Apr 16, 2022 •
edited
Loading

Enables the user to manipulate the document model

  • Adds new TextDocument object
  • Encapsulates editing functionality into TextEditor
  • Supports linear traversal over a tree structure
  • Simple reliable cursor support
  • Insertion, deletion, and replacement
  • A TextMark structure which represents a position within a document

TODO:

  • More robust movement
  • Use per-paragraph indexing
  • Return or split functionality
  • Fix crashes involving selections/replacement
  • Handle start/end iters in both directions
  • Generic way of updating/invalidating mark locations
  • Visually indicate selections Deferred until layout/style rework
  • Grab focus on click
  • Unit tests (Part of Unit Tests #4)
    • insert
    • delete
    • replace
    • movement
    • split
    • mark

mjakeman added 24 commits April 17, 2022 10:28
@mjakeman
display: Add simple insertion and run traversal logic
83b5b29
@mjakeman
node: Assign parent field when adding children
5fc9d13
@mjakeman
display: Allow traversing runs in the forward direction
4de1288
@mjakeman
layout-box: Fix function signature of get_item()
1e1a4a5
@mjakeman
display: Add primitive cursor movement
abbbb9d
@mjakeman
document: Refactor frame and cursor into single document object
e1cd4e2
@mjakeman
editor: Refactor editing interface into new object
01ae495
@mjakeman
layout: Add rudimentary support for cursors
c217502
@mjakeman
editor: Implement backwards traversal
4db110a
@mjakeman
editor: Add shortcuts to move to start/end of document
aa170e0
@mjakeman
node: Implement functions for deleting nodes/children
574b085
@mjakeman
node: Correct counting of number of children
636f5d7
@mjakeman
editor: Implement deletion
1420ef8
@mjakeman
editor: Rework deletion logic
6af75bf 
Use a more general deletion function which can delete
any length of text from any index safely
@mjakeman
editor: Implement replacement and reworked movement
ccbd6b0
@mjakeman
editor: Rework movement to allow specifying a mark
4f9facc
@mjakeman
editor: Fix replacement length calculation
3ae3fd9
@mjakeman
todo: Commit to-do list
0549136
@mjakeman
editor: Create special API for cursor/selection manipulation
fb58351
@mjakeman
test: Add insertion tests
6e555a9
@mjakeman
editor: Fix movement code to pass test cases
50567eb
@mjakeman
test: Add simple movement tests
da1ac0d
@mjakeman
test: Add license header for insert tests
fd019f1
@mjakeman
editor: Make movement tests pass
1179b34
@mjakeman
Copy link
Owner Author

Design doc for caret positions and indexing:

image

mjakeman added 24 commits April 21, 2022 02:48
@mjakeman
editor: Rewrite movement functions to pass all tests
e6d4ba9
@mjakeman
test: Add a few more movement tests
8058e3e
@mjakeman
test: Add new deletion test suite
18636ce
@mjakeman
display: Add CSS class name
a88d94f
@mjakeman
test: Greatly expand deletion unit tests
af6306d
@mjakeman
editor: Rewrite deletion logic from scratch
52c9fe1
@mjakeman
test: Add paragraph deletion tests]
cb7321f
@mjakeman
editor: Handle inverse deletion that is out of bounds
7fc42d4
@mjakeman
test: Add final deletion tests
f3f7825
@mjakeman
paragraph: Add accessor for paragraph text content
e620ae4
@mjakeman
editor: Add guards for NULL marks
1f558d0
@mjakeman
editor: Account for paragraph boundaries in length between calc
7179cbf
@mjakeman
test: Add replacement tests
cf8347a
@mjakeman
test: Add reverse test for replacement
309f1df
@mjakeman
editor: Account for mark order when replacing
d064b9a
@mjakeman
editor: Add split implementation
e630c97
@mjakeman
test: Add split tests
3c60a19
@mjakeman
display: Focus on click
2a0700e
@mjakeman
model: Introduce new generalised mark handling system
5e3bd5f
@mjakeman
node: Rework unparent/delete/clear for tree structure
e446f80
@mjakeman
editor: Implement multi-paragraph deletion
c785844
@mjakeman
test: Add tests for updating marks after a deletion
446b8eb
@mjakeman
editor: Fix mark handling after a multi-paragraph deletion
86743c9
@mjakeman
test: Add final mark tests for insert/split
4ac103e
@mjakeman mjakeman marked this pull request as ready for review April 22, 2022 14:53
@mjakeman mjakeman enabled auto-merge April 22, 2022 15:16
@mjakeman mjakeman merged commit d1f2e91 into master Apr 22, 2022
@mjakeman mjakeman deleted the input branch April 22, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mjakeman