Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt5-base] fix vcpkg-cmake-wrapper to find debug libs on macOS #24

Merged
merged 1 commit into from
Sep 12, 2021
Merged

[qt5-base] fix vcpkg-cmake-wrapper to find debug libs on macOS #24

merged 1 commit into from
Sep 12, 2021

Conversation

Be-ing
Copy link

@Be-ing Be-ing commented Sep 12, 2021

Qt libraries have _debug suffix. pcre has no suffix for its debug
build.

@Be-ing
[qt5-base] fix vcpkg-cmake-wrapper to find debug libs on macOS
6e5a2f1 
Qt libraries have _debug suffix. pcre has no suffix for its debug
build.
@Be-ing Be-ing mentioned this pull request Sep 12, 2021
Merged
daschuer
daschuer approved these changes Sep 12, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.
Since vcpkg-cmake-wrapper.cmake is not used to build the environment, we can merge without finishing the build.

@daschuer daschuer merged commit b124ddc into 2.4 Sep 12, 2021
@Be-ing Be-ing deleted the qt_debug_fix branch September 12, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @daschuer