Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sndfile] enable external-libs for FLAC and OGG #131

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Mar 4, 2024

This aims to fix mixxxdj/mixxx#10880

@daschuer daschuer changed the title [sndfile] enable external-libs for FLAG and OGG [sndfile] enable external-libs for FLAC and OGG Mar 4, 2024
@daschuer
Copy link
Member Author

daschuer commented Mar 9, 2024

@fwcd can you have a look here?

@fwcd
Copy link
Member

fwcd commented Mar 9, 2024

If this builds, I see no reason not to merge this. I could first test this when we have a Mixxx build though.

@daschuer
Copy link
Member Author

daschuer commented Mar 9, 2024

I think we can just merge it. We have anyway the out of disc issue.
I considering to prepare a rsync based clean up script.

@JoergAtGithub
Copy link
Member

I could reproduce mixxxdj/mixxx#10880 on my Windows 11 system. Replacing the buildenv with the version from this PR solved the bug!
Thank you!

@JoergAtGithub JoergAtGithub merged commit 450a843 into mixxxdj:2.4 Mar 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants