log messages before asserting in DAO classes. #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
Aug 21, 2022
| qWarning() << "No valid key detected in analyzed window:" << iKey; | ||
| DEBUG_ASSERT(false); |
There was a problem hiding this comment.
I know that you log a message immediate before this assertion, but maybe the order becomes confusing due to logging from multiple threads or something.
I suggest that you put a message into the assertion like this:
Suggested change
| DEBUG_ASSERT(false); | |
| DEBUG_ASSERT(!"chromatic key is invalid"); |
|
Waiting for CI. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was helpful during debugging a DB issue.