EngineBuffer: avoid std::bad_alloc() in WaveformRenderBeat::draw() when loading a track with active passthrough #4787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1977662
See comments for explanations.
I'm not sure if this is the best solution, though I consider it safe since the queued seek position is set as soon as passthrough is disabled.
We may as well prohibit loading tracks in passtrhough decks, though I didn't look into this approach.
The fix for main is slightly different: with
mixxx::audio::FramePos
we can usesetNewPlaypos(mixxx::audio::kStartFramePos);
Note: the 'symptom' of the bug, "Non-terminating iterator, unlimited growth of memory, crash when calling m_beats.resize()." as @uklotzde pointed out, in
WaveformRenderBeat::draw()
is not addressed here (and I don't know how to fix it).