Traktor S3: Fix issues with sampler and hotcue buttons #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ywwg
commented
Feb 12, 2022
ywwg
commented
- Properly re-light buttons on track load
- Fix hotcues not changing color when color is updated
- Fix sampler buttons not changing color on play
- Default to 8, not 16 samplers (deck 2 sampler buttons duplicate samplers 1-8)
* Properly re-light buttons on track load * Fix hotcues not changing color when color is updated * Fix sampler buttons not changing color on play * Default to 8, not 16 samplers (deck 2 sampler buttons duplicate samplers 1-8)
Holzhaus
approved these changes
Feb 23, 2022
Can you open a PR to update the manual please? At least the "Button Pads" section still describes the old behavior. Then we can merge. |
|
will do. thanks for the review |
|
Is there anythng left to do here?
@ywwg just curious, what's the reason to change this? |
Swiftb0y
approved these changes
Apr 20, 2022
I was getting annoyed during a performance. I wanted the hotcues on one track, but still wanted access to the samplers. With the default set at 16, you can't use the hotcues on deck 1 and also access samples 1-8 |
|
I believe there is nothing left to do one this |
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
|
Sorry this fell under the table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.