Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Denon mc7000 parameter buttons #4310

Closed
wants to merge 3 commits into from

Conversation

flosse
Copy link
Contributor

@flosse flosse commented Sep 19, 2021

Motivation:
Currently the parameter buttons modify the stars of a track or (if shifted) it changes the color.
I never used this functionality and if I would, I'd do that at home at the laptop and not at stage
whereas during a live performance I really like to have quick access to buttons for beat jumps.

If somebody really like to keep the old behavior I could introduce a boolean flag in the script,
otherwise I'd suggest do map this as default behavior.

Note:
This is based on #4307 but if you like me to rebase it to 2.3 branch just tell me :)

@flosse
Copy link
Contributor Author

flosse commented Sep 19, 2021

BTW:
I'm going to remove the code style issues in a separate commit soon.

@ronso0
Copy link
Member

ronso0 commented Sep 19, 2021

Please describe the new button configuration in detail in the first post.

parameter buttons modify the stars of a track or (if shifted) it changes the color.
I never used this functionality and if I would, I'd do that at home at the laptop and not at stage
whereas during a live performance

I often change the star rating from the controller as I hate to use the trackpad for that -- btw that's why I added the stars-up/down controls to Mixxx ; )
Seriously, I think there are users who prefer either configuration, both are valid IMO, while there's probably higher demand for beatjump controls. That said I suggest to go with the bool flag.

@ronso0
Copy link
Member

ronso0 commented Sep 19, 2021

Oh, it looks like this is your first contribution!
Please sign the [contributor agreement] and comment here afterwards.

Thank you!

@ronso0
Copy link
Member

ronso0 commented Sep 19, 2021

@toszlanyi What are your thoughts?

@flosse Please also open a PR for the manual https://github.com/mixxxdj/manual/ to change the mapping documentation accordingly.

@flosse
Copy link
Contributor Author

flosse commented Sep 19, 2021

Oh, it looks like this is your first contribution!

not really.. see #206 😄

Please sign the [contributor agreement]

ok, I can do that additionally.

@flosse
Copy link
Contributor Author

flosse commented Sep 19, 2021

@flosse Please also open a PR for the manual https://github.com/mixxxdj/manual/ to change the mapping documentation accordingly.

sure, I'll do that. already done :)

@flosse flosse changed the title Denon mc7000 parameter buttons [WIP]: Denon mc7000 parameter buttons Sep 19, 2021
@flosse flosse force-pushed the denon-mc7000-parameter-buttons branch 4 times, most recently from d1997d9 to 2e01bd9 Compare September 20, 2021 02:02
@flosse flosse force-pushed the denon-mc7000-parameter-buttons branch from 2e01bd9 to 97f965e Compare September 20, 2021 02:07
@flosse flosse changed the base branch from main to 2.3 September 20, 2021 08:40
@toszlanyi
Copy link
Contributor

toszlanyi commented Sep 22, 2021

during a live performance I really like to have quick access to buttons for beat jumps.

Hello @flosse - In my first mapping I used the Parameter buttons as beatjump too but changed them with the Mixxx 2.3 update as Beatjump is available with the performance pads -> Slicer mode. I already updated the mapping to implement a counter with the pad LEDs. Please refer to the user manual.

I often change the star rating from the controller as I hate to use the trackpad for that -- btw that's why I added the stars-up/down controls to Mixxx ; )

@ronso0 - I really like to be independent of the laptop too and would keep the star and color mod by controller as well.

EDIT: Just wanna make sure to let you know that I am not in favor of this modification. Thanks a lot.

@ronso0
Copy link
Member

ronso0 commented Sep 25, 2021

Beatjump is available with the performance pads -> Slicer mode

In that case I recommend to keep the stars/color controls, but add the beatjump controls as quick access alternative, activated by the bool flag in the script file as you suggested @flosse

@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Dec 25, 2021
@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Sep 12, 2023
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Dec 15, 2023
@daschuer daschuer changed the base branch from 2.3 to 2.4 June 9, 2024 15:41
@fwcd
Copy link
Member

fwcd commented Sep 6, 2024

#13589 has now been merged to 2.5, which implements this.

@fwcd fwcd closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller mappings stale Stale issues that haven't been updated for a long time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants