Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Qt atomic operation wrappers into separate header file #4306

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Extract Qt atomic operation wrappers into separate header file #4306

merged 1 commit into from
Sep 19, 2021

Conversation

uklotzde
Copy link
Contributor

Based on #4304 that should be merged first.

@daschuer
Copy link
Member

#4304 is merged now. I wonder why the changes are still in the diff here.

@Be-ing
Copy link
Contributor

Be-ing commented Sep 19, 2021

#4304 is merged now. I wonder why the changes are still in the diff here.

GitHub will show the first commit until the branch is rebased on main.

@uklotzde uklotzde marked this pull request as ready for review September 19, 2021 13:03
@uklotzde
Copy link
Contributor Author

Rebased and cleaned up the comments.

Be-ing
Be-ing approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI

@Be-ing Be-ing merged commit d31c431 into mixxxdj:main Sep 19, 2021
@uklotzde uklotzde deleted the qatomic branch September 19, 2021 14:37
@daschuer daschuer mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
library ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @daschuer @Be-ing