SoundSourceFFmpeg + ReadAheadFrameBuffer: Debugging options #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
reviewed
Aug 25, 2021
Add overridable compile time options for analyzing gaps and overlaps in the decoded audio stream.
|
How do you intend to set this new preprocessor definition? Don't you need to add an option to CMakeLists.txt? |
This would trigger a complete recompile. Setting it manually in the .cpp file is easier for quick testing. Let's leave it as is, no need to pollute CMakeLists.txt. The comment just mentions both options. |
Be-ing
approved these changes
Aug 25, 2021
|
Now included in #4245 since no one pressed merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes and extensions that will help to analyze https://bugs.launchpad.net/mixxx/+bug/1934785.