Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoopingControl: Replace most double sample positions with mixxx::audio::FramePos #4189

Merged
merged 4 commits into from
Aug 16, 2021
Merged

LoopingControl: Replace most double sample positions with mixxx::audio::FramePos #4189

merged 4 commits into from
Aug 16, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Aug 8, 2021

Based on #4186.

@coveralls
Copy link

coveralls commented Aug 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1132407919

  • 247 of 300 (82.33%) changed or added relevant lines in 4 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 25.96%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/engine/controls/cuecontrol.cpp 2 3 66.67%
src/engine/controls/loopingcontrol.cpp 236 288 81.94%
Files with Coverage Reduction New Missed Lines %
src/engine/enginevumeter.cpp 1 90.24%
src/engine/controls/loopingcontrol.cpp 7 82.64%
Totals Coverage Status
Change from base Build 1127725238: -0.02%
Covered Lines: 19981
Relevant Lines: 76967
💛 - Coveralls

@Holzhaus Holzhaus force-pushed the loopingcontrol-framepos branch from 63d8aab to 574a41b Compare August 8, 2021 15:22
@Holzhaus Holzhaus mentioned this pull request Aug 8, 2021
Merged
@Holzhaus Holzhaus marked this pull request as draft August 8, 2021 22:40
@Holzhaus
Copy link
Member Author

Holzhaus commented Aug 8, 2021

Marked as draft until prerequisite has been merged.

@Holzhaus Holzhaus force-pushed the loopingcontrol-framepos branch from 574a41b to cb09495 Compare August 10, 2021 22:53
@Holzhaus Holzhaus marked this pull request as ready for review August 10, 2021 22:54
uklotzde
uklotzde reviewed Aug 12, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found a minor typo. Please check why codespell didn't detect this?

Thanks for not modifying the existing code. This helps to quickly review such refactorings. With the additional type-safety updating the code late becomes much safer.

src/engine/controls/loopingcontrol.cpp Outdated Show resolved Hide resolved
@uklotzde
Copy link
Contributor

I have verified that our codespell hook doesn't work.

@Holzhaus Holzhaus force-pushed the loopingcontrol-framepos branch from cb09495 to b99748f Compare August 15, 2021 09:44
@Holzhaus Holzhaus requested a review from uklotzde August 16, 2021 18:50
uklotzde
uklotzde approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since no one else showed up for a review let's merge. LGTM

@uklotzde uklotzde merged commit a9c6378 into mixxxdj:main Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
code quality
Projects
Semanting Type Refactoring
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Holzhaus @coveralls @uklotzde