Skins: append / when setting skin base path #4151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures stylesheet icon urls without leading / are transformed to correct paths.
Regression from #3877, noticed with DarkMetal https://mixxx.discourse.group/t/crates-playlists-history-etc-vanish-from-dark-metal/22704/ : the user assumed the library was broken because the sidebar expand arrow icons were missing...
So my hasty conclusion was wrong
mixxx/src/skin/legacy/legacyskinparser.cpp
Lines 2311 to 2313 in 1557ef2
because the skin base path is also set by LegacySkinParser::parseSkin() without trailing /
Appending the / will result in // but this is filtered by Qt later on (assuming since leading / are used for the LateNight launch image and that works on all platforms)
Proposed Changelog entry