Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lp1937074: Fix synchronization of main cue point/position #4137

Merged
merged 2 commits into from
Jul 24, 2021
Merged

lp1937074: Fix synchronization of main cue point/position #4137

merged 2 commits into from
Jul 24, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde added this to the 2.4.0 milestone Jul 24, 2021
@uklotzde uklotzde requested a review from Holzhaus July 24, 2021 10:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1062314730

  • 7 of 15 (46.67%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 28.631%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/track/track.cpp 2 4 50.0%
src/engine/controls/cuecontrol.cpp 2 8 25.0%
Files with Coverage Reduction New Missed Lines %
src/engine/enginevumeter.cpp 1 90.24%
Totals Coverage Status
Change from base Build 1062297747: -0.002%
Covered Lines: 20104
Relevant Lines: 70217
💛 - Coveralls

daschuer
daschuer approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 2435cee into mixxxdj:main Jul 24, 2021
@uklotzde uklotzde deleted the lp1937074-cuecontrol branch July 24, 2021 14:18
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@Holzhaus Holzhaus Awaiting requested review from Holzhaus

Assignees
No one assigned
Labels
minor bug
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @coveralls @daschuer