Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Donate button to About dialog #3838

Merged
merged 2 commits into from
May 7, 2021
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 7, 2021

image

https://mixxx.zulipchat.com/#narrow/stream/247619-UI-.26.20UX.20design/topic/add.20Donate.20button.20to.20Help.20menu.3F

  • add /donate relay at mixxx.org? so we can change the donate method/link without having to change anything else
  • nice icons

@github-actions github-actions bot added the ui label May 7, 2021
@ronso0 ronso0 added this to the 2.3.0 milestone May 7, 2021
@daschuer
Copy link
Member

daschuer commented May 7, 2021

Thank you for picking it up.
The heart is already a nice icon.
If we have alternatives, we may randomize them to draw attention if a user opens the window a second time. Just an idea.

The other idea is: do we want to modify the button text or a lable an online source to point out donation targets or anything else?

src/defs_urls.h Outdated
Comment on lines 7 to 9
#define MIXXX_DONATE_URL \
"https://www.paypal.com/cgi-bin/" \
"webscr?cmd=_s-xclick&hosted_button_id=QSFMYWN2B3JD2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define MIXXX_DONATE_URL \
"https://www.paypal.com/cgi-bin/" \
"webscr?cmd=_s-xclick&hosted_button_id=QSFMYWN2B3JD2"
#define MIXXX_DONATE_URL "https://mixxx.org/donate"

after mixxxdj/website#238 has been merged

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless Mixxx is transformed into a legal entity, accepting donations raises more questions than answers. It is a gray area at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixxx always took donations, I can even see a donation button on our website in 2008 when I use the Wayback Machine. I do agree that we should think about founding an e.V. or joining the SFC, but I don't think this should hold back this PR.

Maybe you want to share your thoughts on these Zulip threads:

@ronso0
Copy link
Member Author

ronso0 commented May 7, 2021

If we have alternatives, we may randomize them to draw attention if a user opens the window a second time. Just an idea.

yeah, this might help. if someone wants look into that, fine.
alternative: pick up the rainbow from the Mixxx logo
image

just the outline:
image

For now the plain monochrome heart is fine IMO. Like the preferences icons it appears in black or white, depending on the OS theme.

@ronso0
Copy link
Member Author

ronso0 commented May 7, 2021

Ready?

@ronso0 ronso0 marked this pull request as ready for review May 7, 2021 14:11
src/dialog/dlgabout.cpp Outdated Show resolved Hide resolved
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

If you add the rainbow icon, I can contribute the lines showing it by a chance of 1/8 or such.

@Holzhaus merge?

@daschuer
Copy link
Member

daschuer commented May 7, 2021

No, there is a pending comment ...

@Holzhaus
Copy link
Member

Holzhaus commented May 7, 2021

The build failed due to some sccache error, I restarted it.

@ronso0
Copy link
Member Author

ronso0 commented May 7, 2021

If you add the rainbow icon, I can contribute the lines showing it by a chance of 1/8 or such.

@daschuer Go ahead, the rainbow icon is in place.

@ronso0
Copy link
Member Author

ronso0 commented May 7, 2021

If you add the rainbow icon, I can contribute the lines showing it by a chance of 1/8 or such.

@daschuer Go ahead, the rainbow icon is in place.

or we just merge this, and you apply that in a follow-up. I don't mind

@Holzhaus Holzhaus merged commit 8ee1926 into mixxxdj:2.3 May 7, 2021
@ronso0 ronso0 deleted the donate-button branch May 7, 2021 22:03
@ronso0
Copy link
Member Author

ronso0 commented May 7, 2021

The other idea is: do we want to modify the button text or a lable an online source to point out donation targets or anything else?

To indicate we're using PayPal? Or what do you want to point out?

@Holzhaus
Copy link
Member

Holzhaus commented May 7, 2021

Or do you mean other projects (e. g. our dependencies)?

By the way, should we add a tab that lists those dependencies? Would be a nice gesture to mention and add links to them I think.

@ronso0
Copy link
Member Author

ronso0 commented May 7, 2021

all dependencies? group all libqt*, also include the static libs like xwax?

@Holzhaus
Copy link
Member

Holzhaus commented May 7, 2021

Just a list like:

  • Qt
  • xwax
  • KeyFinder
  • SoubdTouch
  • Rubberband
  • modplug
  • Chromaprint
  • FLAC
  • OGG
  • Vorbis
  • LAME
  • FFTW
  • Ebur128
  • PortAudio
  • PortMidi
  • SndFile
  • TagLib
  • MP4
  • FFMPEG
  • HSS1394
  • libshout-idjc
  • SQLite
  • Opus
  • MAD
  • ID3Tag
  • WavPack
  • LibUSB
  • HIDAPI
  • lilv

Plus links to their websites

@ronso0
Copy link
Member Author

ronso0 commented May 8, 2021

Do you imagine a second tab in About? with a 2-colum list

@daschuer
Copy link
Member

daschuer commented May 8, 2021

The other idea is: do we want to modify the button text or a lable an online source to point out donation targets or anything else?

To indicate we're using PayPal? Or what do you want to point out?

The idea was something like "$ 546 left to .." but scratch that idea. Such a lookup may violate users privacy.

We can integrate it into an update announcer later on if we feel there is a need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants