-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Donate button to About dialog #3838
Conversation
Thank you for picking it up. The other idea is: do we want to modify the button text or a lable an online source to point out donation targets or anything else? |
src/defs_urls.h
Outdated
#define MIXXX_DONATE_URL \ | ||
"https://www.paypal.com/cgi-bin/" \ | ||
"webscr?cmd=_s-xclick&hosted_button_id=QSFMYWN2B3JD2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#define MIXXX_DONATE_URL \ | |
"https://www.paypal.com/cgi-bin/" \ | |
"webscr?cmd=_s-xclick&hosted_button_id=QSFMYWN2B3JD2" | |
#define MIXXX_DONATE_URL "https://mixxx.org/donate" |
after mixxxdj/website#238 has been merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless Mixxx is transformed into a legal entity, accepting donations
raises more questions than answers. It is a gray area at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixxx always took donations, I can even see a donation button on our website in 2008 when I use the Wayback Machine. I do agree that we should think about founding an e.V. or joining the SFC, but I don't think this should hold back this PR.
Maybe you want to share your thoughts on these Zulip threads:
Ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you.
If you add the rainbow icon, I can contribute the lines showing it by a chance of 1/8 or such.
@Holzhaus merge?
No, there is a pending comment ... |
The build failed due to some sccache error, I restarted it. |
@daschuer Go ahead, the rainbow icon is in place. |
or we just merge this, and you apply that in a follow-up. I don't mind |
To indicate we're using PayPal? Or what do you want to point out? |
Or do you mean other projects (e. g. our dependencies)? By the way, should we add a tab that lists those dependencies? Would be a nice gesture to mention and add links to them I think. |
all dependencies? group all libqt*, also include the static libs like xwax? |
Just a list like:
Plus links to their websites |
Do you imagine a second tab in About? with a 2-colum list |
The idea was something like "$ 546 left to .." but scratch that idea. Such a lookup may violate users privacy. We can integrate it into an update announcer later on if we feel there is a need. |
https://mixxx.zulipchat.com/#narrow/stream/247619-UI-.26.20UX.20design/topic/add.20Donate.20button.20to.20Help.20menu.3F