Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use SSH Agent to deploy to download server #3809

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Conversation

Holzhaus
Copy link
Member

No description provided.

@Holzhaus Holzhaus added the build label Apr 27, 2021
@Holzhaus Holzhaus force-pushed the deploy-improvements branch 9 times, most recently from a664d90 to 2ef8915 Compare April 28, 2021 22:37
@Holzhaus Holzhaus force-pushed the deploy-improvements branch from 2ef8915 to 132768f Compare April 29, 2021 00:08
@Holzhaus Holzhaus marked this pull request as ready for review April 29, 2021 01:03
@Holzhaus
Copy link
Member Author

OK, I finally found a way to work around the MSYS2 cygheap corruption. This is ready now.

@Holzhaus Holzhaus requested a review from daschuer April 29, 2021 16:49
@daschuer
Copy link
Member

Thank you for digging that down. I don't see any obvious issue.
Did you double check that we do not expose secrets? It looks like GitHub does it well for us, right?

@Holzhaus
Copy link
Member Author

No, I don't think this will expose our secrets. Ready to merge IMHO.

@daschuer daschuer merged commit c30a4b8 into 2.3 Apr 30, 2021
@daschuer
Copy link
Member

Thank you for all this nerve-racking work ...

@Holzhaus Holzhaus deleted the deploy-improvements branch May 7, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants