Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Try to detect hidapi version if not already set #3732

Closed
wants to merge 1 commit into from
Closed

CMake: Try to detect hidapi version if not already set #3732

wants to merge 1 commit into from

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde requested a review from Holzhaus March 19, 2021 19:19
@github-actions github-actions bot added the build label Mar 19, 2021
@Holzhaus
Copy link
Member

Maybe we shouldn't do this after all. We'd need to cache hidapi_VERSION, but then the version will be wrong when updating hidapi without deleting the build dir. Sorry, I didn't think of that before. @uklotzde what do you think?

@uklotzde
Copy link
Contributor Author

I wondered who else may initialize hidapi_VERSION? If no one does then let's drop this PR.

@uklotzde uklotzde closed this Mar 19, 2021
@uklotzde uklotzde deleted the cmake-hidapi-version branch March 20, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Awaiting requested review from Holzhaus

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Holzhaus