-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPSCQueue: hack around libc++ bug on macOS #3318
Conversation
Could you post the fix upstream, so that we can just update our library copy? |
I don't know if that would be appropriate. The bug was in LLVM's libc++ and has already been fixed. SPSCQueue is doing it right according to the C++ standard. |
This custom |
Still unimplemented, so no need for a more specific check: |
There are macros for the clang version number, but I do not know how to get the libc++ version. I am unclear if each version of clang must be used with a certain libc++ version or if they are independent. |
CI passed. Merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully we don't forget to re-add this patch when updating from upstream. LGTM
CI will catch this quickly if we do forget it. |
See PR mixxxdj#3318 for more info
No description provided.