Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPSCQueue: hack around libc++ bug on macOS #3318

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Nov 14, 2020

No description provided.

@Holzhaus
Copy link
Member

Could you post the fix upstream, so that we can just update our library copy?

@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 14, 2020

I don't know if that would be appropriate. The bug was in LLVM's libc++ and has already been fixed. SPSCQueue is doing it right according to the C++ standard.

@uklotzde
Copy link
Contributor

This custom workaroundhack is not suitable for an upstream fix. Are we able to restrict it to selected LLVM/Clang versions?

@uklotzde
Copy link
Contributor

uklotzde commented Nov 15, 2020

Still unimplemented, so no need for a more specific check:
https://libcxx.llvm.org/docs/FeatureTestMacroTable.html

@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 15, 2020

There are macros for the clang version number, but I do not know how to get the libc++ version. I am unclear if each version of clang must be used with a certain libc++ version or if they are independent.

@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 15, 2020

CI passed. Merge?

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we don't forget to re-add this patch when updating from upstream. LGTM

@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 16, 2020

Hopefully we don't forget to re-add this patch when updating from upstream.

CI will catch this quickly if we do forget it.

ferranpujolcamins added a commit to ferranpujolcamins/mixxx that referenced this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants