Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adjust skin styles to show the onsceen keyboard during libary search #3231

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Oct 28, 2020

With these syle fixes the onscreen keyboard is shown.
Unfortunately it does an endeless show hide cycle. This can also be seen with VLC player.

More details are here.
https://bugs.launchpad.net/mixxx/+bug/1439884

I am curious to hear if this lints also the onscreen keyboard

The styled border was the issue, now it is back to OS border which looks ugly.

@github-actions github-actions bot added the skins label Oct 28, 2020
@ronso0
Copy link
Member

ronso0 commented Oct 29, 2020

Before we mess up the styles, could you check how Onboard behaves with #3171 ?
And what happen when we set a 0px border here?

@ronso0 ronso0 marked this pull request as draft October 29, 2020 00:43
@daschuer
Copy link
Member Author

A 0 px border also disabled the touch keyboard.
For my impression anything that touches the border disabled the on screen keyboard.

Since this PR was just a result of try and error I am not satisfied with the solution.

I think we need to dig down to the code that let the keyboard pop up. Than wecan decide for a split solution.

This patch does currently not help the user, because the keyboard it bumping in the rhythm of the cursor.

At least we are now head up with the QT gui of vlc player.

@daschuer
Copy link
Member Author

Original the bug was reported for Windows 8, which has a minimum market share. I am interested about the current state on all our targets.

@daschuer
Copy link
Member Author

The combo box search PR alown does not fix the issue. but it works after merging.

@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jan 29, 2021
@ronso0 ronso0 changed the title [WIP] Adjust skin styles to show the onboard keyboard during libary search [WIP] Adjust skin styles to show the onsceen keyboard during libary search Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skins stale Stale issues that haven't been updated for a long time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants