Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search related track: remove quotes #3228

Closed
wants to merge 1 commit into from

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 27, 2020

quotes
no-quotes

Simply removes noise from the menu.
If you think the search term doesn't stand out enough now, we could add an additional whitespace before the term:
no-quotes-space

Maybe there are also ways to change the font-weight or color.

@ronso0 ronso0 requested a review from uklotzde October 27, 2020 18:02
@github-actions github-actions bot added the ui label Oct 27, 2020
@uklotzde
Copy link
Contributor

The PR will conflict with #3213. Let's use this PR to collect opinions (before/after screenshots) and then directly implement the changes in #3213.

@ronso0 ronso0 marked this pull request as draft October 27, 2020 18:18
@JoergAtGithub
Copy link
Member

IMHO the field name and the value should differ more visible. Quotes are not optimal - what about using a fixed width font for the value? Or display the fieldname as the labels here in GitHub?

@uklotzde
Copy link
Contributor

I find the text without the quotes hard to distinguish. Introducing QWidgetAction for custom styling requires more work.

@ronso0
Copy link
Member Author

ronso0 commented Oct 28, 2020

For me it's hard to read with quotes :\

The example with 2 spaces works for me (3rd screenshot), but we can also look for strong unicode chars to separate the search term. Some inspiration (not all to be taken seriously):
Album Artist: "Roland Kaiser"
Album Artist „Roland Kaiser”
Album Artist: [ Roland Kaiser ]
Album Artist = Roland Kaiser
Album Artist ⊳ Roland Kaiser
Album Artist ☞ Roland Kaiser

@uklotzde
Copy link
Contributor

The right triangle looks intuitive

@ronso0
Copy link
Member Author

ronso0 commented Oct 28, 2020

The right triangle looks intuitive

there are more variants (lighter, heavier, other proportions) in case it looks to heavy when rendered bold/semi-bold in the menus.

@uklotzde
Copy link
Contributor

@ronso0 This PR might be obsolete now with the latest additions and changes in #3213 (see screenshot)

@ronso0 ronso0 closed this Oct 29, 2020
@ronso0 ronso0 deleted the searchrelated-no-quotes branch October 29, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants