Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some -Wfloat-conversion warnings (Pt. 7) #3128

Merged
merged 9 commits into from
Oct 16, 2020
Merged

Fix some -Wfloat-conversion warnings (Pt. 7) #3128

merged 9 commits into from
Oct 16, 2020

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Sep 25, 2020 •
edited
Loading

Only beatgrid.cpp and beatmap.h are left.

@Holzhaus Holzhaus added this to the 2.3.0 milestone Sep 25, 2020
@Holzhaus Holzhaus mentioned this pull request Sep 25, 2020
Merged
11 tasks
daschuer
daschuer approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM waiting for CI.

@Holzhaus
Copy link
Member Author

Holzhaus commented Oct 9, 2020

Merge?

@Holzhaus
Copy link
Member Author

Ping

@daschuer daschuer merged commit 842c0ba into mixxxdj:2.3 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @daschuer