Build: Enable warning -Woverloaded-virtual #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prerequisite for enabling -Woverloaded-virtual
|
@Holzhaus I didn't find a solution for suppressing the following warning during the build: |
cc1: warning: command-line option ‘-Woverloaded-virtual’ is valid for C++/ObjC++ but not for C
"Fixed" by renaming the file 🙈 |
Holzhaus
approved these changes
Aug 25, 2020
|
@Holzhaus Wait a moment. The renamed Q_INVOCABLE in HidControllerJSProxy could cause issues. I'll check if this was really necessary. |
Reverted. Locally builds without errors. |
|
OSX/clang/SCons spoils all Travis CI builds. We need to get rid of it. |
|
Ping |
|
Pingping |
Holzhaus
approved these changes
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option helps to detect unintended overloading of non-virtual methods from base classes. Could have detected the obsolete slots fixed in #3044.
As a prerequisite, some fixes in the controller subsystem were required. The backport to 2.3 would require some effort due to differences in the class hierarchy. I neither have the time nor motivation to sort this out.