hack around macOS segfault on startup #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only subtle difference that I noticed is that the charcter literal is explicitly wrapped into a QStringLiteral() in the Qt docs: https://doc.qt.io/qt-5/qloggingcategory.html#setFilterRules Worth a try? I'm not sure if the implicit string conversion at runtime might affect this crash and why. |
|
Alright, I'll merge this and get a master build going for someone on macOS to test. If this doesn't fix the crash, it probably doesn't hurt anything either. And if it does hurt something, it would be trivial to revert. |
daschuer
added a commit
to daschuer/mixxx
that referenced
this pull request
Nov 16, 2021
introduced in mixxxdj#2635 and commit 8ee1dd3.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1871238
I don't know why this is leading to a segfault, but if I understand correctly this code is only needed on Linux anyway.