fix version check on preferences upgrade #2232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Aug 9, 2019
src/preferences/upgrade.cpp
Outdated
| configVersion.startsWith("2.1.0")) { | ||
| // No special upgrade required, just update the value. | ||
| else { | ||
| // Vesrion seems to be never or equal v"1.12" so, no special upgrade required, just update the value. |
There was a problem hiding this comment.
Typo and wording
The common else branch is also wrong, because it will silently downgrade to a lower version. I mentioned in my bug report that this case needs to be handled properly. It involves parsing the first 2 or 3 digits (major, minor, patch) from the version number string. You also need to consider pre-releases that might have an arbitrary suffix, so the parse must be kind of lazy.
|
Why is this targeted at 2.1? We are no longer maintaining 2.1. I think this should go to the 2.2 branch. |
|
to be honest, I do no longer work active on this, someone else might take this over to finish |
|
I'll close this PR. Please feel free to open a new PR when ready again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up for #2231 but this time against branch 2.1