-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable track metadata export for .ogg files and TagLib 1.11.1 #2180
Disable track metadata export for .ogg files and TagLib 1.11.1 #2180
Conversation
Wait, do we know if this only affects OGG/Vorbis or any OGG container file? |
According to the analysis in taglib/taglib#864 only Ogg files are affected. I will restrict the workaround to Ogg file access instead of writing VorbisComment tags as now. |
I've force pushed a different version that restricts the workaround to write access of |
This compile-time check is still insufficient and the wrong strategy. What we actually need is a runtime check, because on most platforms TagLib is linked dynamically. I'm not aware of any function that accomplishes that. I'm really concerned about the way such a critical bug in one of our basic dependencies is handled. Unfortunately there is currently no alternative for TagLib. |
What is the scenario, such a check is required? On Linux we can rely on the package manager. |
@Pegasus-RPG merge? |
Let's just rely on the static build time check. It should be sufficient for most use cases. Anything else to do? We should release this asap to prevent further damage. |
OK |
I'll resolve the conflicts with master, caused by reformatting. |
Required to fix writing tags to Ogg Vorbis files: taglib/taglib#864 https://bugs.launchpad.net/mixxx/+bug/1833190 mixxxdj/mixxx#2180
Just an ugly workaround for https://bugs.launchpad.net/mixxx/+bug/1833190 and taglib/taglib#864.