-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.2.1 #2019
Release 2.2.1 #2019
Conversation
I do not think it is a good idea to release this until we try to get wider testing for #1953. Unfortunately that is blocked on the build server not working... |
43383aa
to
d6c8a85
Compare
Yes, of cause, we need a working CI on Jenkins anyway to publish the release. |
@daschuer Please also resolve the small typo and the conflicts. Should we backport the fixes from 2.1.8 before actually releasing 2.2.1? |
Yes that was the plane, release 2.18 first and merge it to 2.2 and than release that. |
…9 already existing)
…ware/mixxxdj/mixxx2-2/. Compile QM files out of TS files that are used by the localized app
This is now again up to date. Merge? |
#2057 is just a one line change with 2 supporters, but no feedback yet. |
In the past it has been ok to merge in short changes like that that are not possible for other developers to test (because of lack of hardware) |
Ready to merge again and actually release 2.2.1 |
CHANGELOG
Outdated
@@ -1,3 +1,14 @@ | |||
==== 2.2.1 2019-02-02 ==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release date needs to be updated
Just one minor finding. Thank you @daschuer for doing all the work preparing this release! |
Thank you fro review. |
This is the release PR of a possible 2.2.1 release.
I think it is reasonable to do it now, to make the 2.1.7 fixes available for all users.
It also induces the important fixes against performance issue in the library.