Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.1 #2019

Merged
merged 7 commits into from
Apr 22, 2019
Merged

Release 2.2.1 #2019

merged 7 commits into from
Apr 22, 2019

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Feb 2, 2019

This is the release PR of a possible 2.2.1 release.
I think it is reasonable to do it now, to make the 2.1.7 fixes available for all users.
It also induces the important fixes against performance issue in the library.

@Be-ing
Copy link
Contributor

Be-ing commented Feb 2, 2019

I do not think it is a good idea to release this until we try to get wider testing for #1953. Unfortunately that is blocked on the build server not working...

@daschuer
Copy link
Member Author

daschuer commented Feb 3, 2019

Yes, of cause, we need a working CI on Jenkins anyway to publish the release.

@daschuer daschuer added this to the 2.2.1 milestone Feb 3, 2019
CHANGELOG Outdated Show resolved Hide resolved
@uklotzde
Copy link
Contributor

@daschuer Please also resolve the small typo and the conflicts. Should we backport the fixes from 2.1.8 before actually releasing 2.2.1?

@daschuer
Copy link
Member Author

Yes that was the plane, release 2.18 first and merge it to 2.2 and than release that.

@daschuer
Copy link
Member Author

This is now again up to date. Merge?

@uklotzde
Copy link
Contributor

#2057 is just a one line change with 2 supporters, but no feedback yet.

@ywwg
Copy link
Member

ywwg commented Apr 18, 2019

#2057 is just a one line change with 2 supporters, but no feedback yet.

In the past it has been ok to merge in short changes like that that are not possible for other developers to test (because of lack of hardware)

@daschuer
Copy link
Member Author

Ready to merge again and actually release 2.2.1

CHANGELOG Outdated
@@ -1,3 +1,14 @@
==== 2.2.1 2019-02-02 ====
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release date needs to be updated

@uklotzde
Copy link
Contributor

Just one minor finding.

Thank you @daschuer for doing all the work preparing this release!

@daschuer daschuer merged commit 286a52a into mixxxdj:2.2 Apr 22, 2019
@daschuer
Copy link
Member Author

Thank you fro review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants