Tooltip issues from Lp1779468

[daschuer]

Some tooltip fixes reported in https://bugs.launchpad.net/mixxx/+bug/1779468
It also equalizes the right click behavior on Samplers and preview decks for all skins.

I have changed the tooltips. The sampler right click follows CUE mode. Does it work?

[ronso0]

I'll test this.
Meanwhile I'm wondering why there are two identical Play buttons in Deere, one for wether [SamplerX],repeat is 0 or not
https://github.com/mixxxdj/mixxx/pull/1752/files#diff-60b5be35479b7006fc2a599dcf8d9522

[daschuer]

In case of repeat enabled, the play button becomes violet. I have added a comment.

[daschuer]

@ronso0: can we merge this now?

[ronso0]

short on time..I'll have a look this evening

[ronso0]

the samplers work fine now.

LateNights missing CUE mark in sampler overview is added in #1754 but in Shadethey're missing:
cbe7580 Shade: add CUE mark to sampler overview
and IMO black marks are better there (if you like):
8663752 Shade: black Sampler overview marks

I noticed the decks' CUE right-click tooltip doesn't match:
all CUE buttons have the tooltip ID cue_default_cue_gotoandstop attached, right-click connection is cue_gotoandstop but AFAICT it shows the text of cue_default

[daschuer]

Thank you for the commits. I have just merged them.

I do not see an issue with the right click Deck CUE buttons. Is it in Shade?

[ronso0]

hmm..its the same in all skins I suppose it will be solved when this is merged to 2.1.

got it: for the samplers's tooltip to work out (cue_gotoandplay_cue_default) you changed cueWhileStopped to "Set cue point (Pioneer/Mixxx/Numark mode), set cue point and play after release (CUP mode) OR preview from it (Denon mode)."
this is also called from cue_default_cue_gotoandstop which is used for decks' CUE buttons, but their right-click connection is cue_gotoandstop that's independent from play state of decks.
in 2.1 this points to correct tooltip "Seeks the track to the cue point and stops." and I suggest to keep https://github.com/mixxxdj/mixxx/pull/1752/files#diff-e131bb07ee88c7ad6d80f4643f558015L427

[daschuer]

Sorry, I cannot follow. I have tested the 2.1 merge commit.
What should we do here next?

[ronso0]

sorry for the confusion. It's easy:
start this branch in dev mode, hover over a deck's CUE button in any skin.
check the right-click connection, have a look at the corresponding tooltip string below.
It doesn't match..

so here we should use QString cueWhilePlaying because all the deck CUE buttons have cue_gotoandstop as right-click connection

[daschuer]

I have got it. It looks like I had accidentally removed the original right click tool tip.now it is back.
Merge?

[ronso0]

LGTM!

[daschuer]

Thank you for help and final review!