lp1719474 Follow-up: Fix navigation usability issues in sidebar tree #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
changed the title
|
I've found a better solution by correctly distinguishing clicks and key presses. This avoids the timeout when clicking and we can choose a timeout that works best just for scrolling. I also forgot to mention that this usability issue also effects keyboard navigation within the sidebar tree, i.e. you can test the behavior without a controller just with your keyboard! Stay tuned... |
uklotzde
changed the title
I've increased the timeout to 300 ms which works very well for me in most situations. |
|
Did a forced update to avoid changes in WLibrarySidebar that were unnecessary. |
|
Works good and LGTM. |
daschuer
reviewed
May 26, 2018
| @@ -210,6 +210,8 @@ void Library::bindSidebarWidget(WLibrarySidebar* pSidebarWidget) { | |||
| connect(m_pSidebarModel, SIGNAL(selectIndex(const QModelIndex&)), | |||
| pSidebarWidget, SLOT(selectIndex(const QModelIndex&))); | |||
| connect(pSidebarWidget, SIGNAL(pressed(const QModelIndex&)), | |||
| m_pSidebarModel, SLOT(pressed(const QModelIndex&))); | |||
| connect(pSidebarWidget, SIGNAL(clicked(const QModelIndex&)), | |||
There was a problem hiding this comment.
This change causes that the activate() is called twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion in #1619
A timeout of
250300 ms still feels responsive and scrolling slowly through the list of playlists and crates is possible. This new timeout is now used for every LibraryFeatureas a default, unless customized in a derived class!