Tango :: polish Play buttons & FX unit expand toggle #1531
Conversation
ronso0
commented
Mar 3, 2018
•
ronso0
commented
- Play/Pause icons appear blurred when using 'image' porperty in qss, although svg height matches the buttons' height > distinct 1:1 sized icons for every instance, also I removed separate icon definitions for 'pressed'/'unpressed' state where unnecessary
- minimized FX unit would flicker when changing FX focus > fix size for that toggle's container
- emphasize Pfl button in FX units & sampler by adding a border to it
- repair right-click function of Key_down & rate_down buttons (fixes lp:1752671)
… definition (except 0-state buttons like Eject), make Play/Pause icons match the button size(s)
Also, in style.qss I recently split 'background' property into 'background-color' and 'image' to make the button icons scale when scaling the skin.
Drawback was that some icons appeared blurred afterwards, although at least their height matched the buttons.
For affected buttons (basically all Play buttons) I switched to inline definition in xml ('state_X_pressed' etc.) and created icons
for every instance (deck, sampler, previewdeck). There's no hover effect for icons anymore, but the icons look great in every situation.
…prevent flickering when altering effect focus
Is that a bug? Is there anything to test here? This skin still looks good |
I can't tell...maybe border is subtracted from button size and the icons get scaled down, maybe it's just a horizontal offset, idk yet. Here it is fixed but I'll investigate this sometime. Testing is welcome, of course. Maybe something slipped through.. |
|
don't merge yet, I'm working on https://bugs.launchpad.net/mixxx/+bug/1753112 |
|
I'm done, please test. |
|
While I was vectorizing the remaining buttons and VU meters for LateNight, I did this for Tango, as well. |
|
Everything looks crisp at 2.5x scale on my 3840 x 2160 screen. I am appreciating the design of this skin more now that I have a 4 deck controller. Great job 👍 |
|
Great, thanks! |
|
I think the best waveform layout depends on the user's controller. Refer to the discussion I pinged you in on Zulip. |
