(fix) Traktor S4mk3: smooth xfader curve for Const Power mode #14305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JK, the difference is the small change at the crossover area in the middle, right? |
| engine.setValue("[Mixer Profile]", "xFaderCurve", 7.0); | ||
| break; | ||
| case 0x01: // Constant Power | ||
| engine.setValue("[Mixer Profile]", "xFaderMode", 1); | ||
| engine.setValue("[Mixer Profile]", "xFaderCalibration", 0.3); | ||
| engine.setValue("[Mixer Profile]", "xFaderCalibration", 0.31498); |
There was a problem hiding this comment.
A short comment on how the "magic" number 0.31498 is calculated would be great :) Is this just the output of EngineXFader::getFaderCalibration(), or something different?
There was a problem hiding this comment.
yes, EngineXfader::getPowerCalibration()
comment added
and remove unused calibration values for Additive modes
ronso0
force-pushed
the
s4mk3-xfader-curve
branch
from
b965b7a to
e689d25
Compare
cr7pt0gr4ph7
approved these changes
Feb 10, 2025
Swiftb0y
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Thank you. Quick checkin as the informal "code owner" for the s4 @acolombier?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove unused calibration values for Additive modes (see #13363 (comment) for details)
before: (slow fade with rather sharp cut)
fix:
