Building without tests-tools 2.5 #14269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPN-SD
force-pushed
the
cmake-mixxx-2.5
branch
2 times, most recently
from
63de578 to
6be2412
Compare
Today, we can't build mixxx without links to gtest/gperftools/benchmark This PR allows building only mixxx and mixxx-lib targets without tests-tools. Two common cmake-definitions are added : * BUILD_TESTING * BUILD_BENCH And one compile definition for test.main.cpp : * USE_BENCH This is helpful for packaging (gentoo here). The negative effect is sorting of tests source files as soon as they are called by mixxx-benchmark target.
PPN-SD
force-pushed
the
cmake-mixxx-2.5
branch
from
6be2412 to
2576977
Compare
|
Ups, I have merged the "main" version. We regularly merge 2.5 to main. So the main version should have been rebase onto 2.5. But never mind, I merge this now and resolve conflicts if there are any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, we can't build mixxx without links to gtest/gperftools/benchmark
This PR allows building only mixxx and mixxx-lib targets without tests-tools.
Two common cmake-definitions are added :
And one compile definition for test.main.cpp :
This is helpful for packaging (gentoo here).
The negative effect is sorting of tests source files as soon as they are called by mixxx-benchmark target.