Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Key Wheel action to View menu #14239

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 26, 2025

Just to have them all in one menu.
The shortcut is [KeyboardShortcuts], ViewMenu_ShowKeywheel already, so .. 🤷

image

Should we change the hotkey to Ctrl+7 so all View items are Ctrl hotkeys? (in main)

yes, i don't see Space for maximize library anymore for some reason..

@github-actions github-actions bot added the ui label Jan 26, 2025
@daschuer
Copy link
Member

Thank you. Does it fit to a the stable branch?

@daschuer
Copy link
Member

Should we change the hotkey to Ctrl+7 so all View items are Ctrl hotkeys? (in main)

Yes.

@ronso0
Copy link
Member Author

ronso0 commented Jan 28, 2025

Thank you. Does it fit to a the stable branch?

IMHO it's a UX fix, so: yes.
Same for changing the hotkey: updates are done explicitly and the info should be in the changelog.
If some is used to F12 they found that in the menu. So if F12 doesn't work anymore they'll likely search the menus for Keywheel and find it in View 🤷

If I overlooked something, or a new hotkey is too much of a breaking change, we may as well update it in main. I don't really care.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, OK than let's just merge.

@daschuer daschuer merged commit 20ea954 into mixxxdj:2.5 Jan 28, 2025
13 checks passed
@ronso0 ronso0 deleted the keywheel-to-view-menu branch January 28, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants