Waveforms: add slip waveform to Textured/'High details' type #14039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So no one missed this? The diff is tiny, I'd appreciate if someone familiar with OpenGL could take a look. |
acolombier
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
LGTM! Thanks for adding the slip support here.
I am not an OpenGL expert so I'll keep this open for now, maybe @m0dB could advises whether or not this is the best approach? Happy to merge and fix forward otherwise, if you prefer that option.
|
Thanks for taking a look! I don't intend to rush this, just wanted to make it pop up in everyone's inbox so it gets attention, and mainly I'm curious if it was actually that easy to implement : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted this so I had a coffe and poked around a bit in the Textured renderer, and after a few quite funny results it looks... great 🎉
No clue what I did here, it's probably not the most efficient way. It's still rendering the entire texture, no?
I have no intention to polish this, so anynone who's interested may push to my branch directly.
One piece to resolve #13499