Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stem control test fix #13960

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Stem control test fix #13960

merged 3 commits into from
Dec 6, 2024

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Dec 2, 2024

This implements waiting for the Deck::newTrackLoaded() signal. An alternative for #13936

In most cases the test continues after only 1 ms in the wait loop, but it may take way longer if the hardware is busy.

…orming tests.

This replaces the uncoditional 100 ms wait time which was not always enough.
In this case the function does not end before the lambda is disconnected.
Copy link
Member

@acolombier acolombier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@acolombier acolombier merged commit 8354c8e into mixxxdj:main Dec 6, 2024
13 checks passed
@acolombier acolombier linked an issue Dec 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky StemControlTest.StemColor
2 participants