Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Track property editor: don't close when opening context menu #13930

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Nov 24, 2024

This slipped through in #11755
Currently the editor is closed on every FocusOut event, but that's wrong if the QLineEdit's menu pops up.
That one seems to be the only event that has the reason Qt::PopupFocusReason so we can filter easily.

@ronso0 ronso0 added this to the 2.5.0 milestone Nov 24, 2024
@github-actions github-actions bot added the ui label Nov 24, 2024
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the issue and the fix.
LGTM

@daschuer daschuer merged commit 9553d51 into mixxxdj:2.5 Nov 26, 2024
13 checks passed
@ronso0 ronso0 deleted the track-prop-edi-menu-fix branch November 27, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants