Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Launchpad X detection on macOS #13691

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix Launchpad X detection on macOS #13691

merged 1 commit into from
Sep 24, 2024

Conversation

frankgrimy
Copy link
Contributor

As stated on #13633, Mixxx wasn't configuring Novation Launchpad X correctly, because of a name mismatch between its input and output interfaces in macOS.

@daschuer
Copy link
Member

The code looks good, thank you. The is just a stray white space character reported by pre-commit.
This can even go to our stable 2.4 branch.
Can you rebase this to 2.4? If you have a local working copy, you may:
git reset upstream/2.4 --hard
git cherry-pick 81d1a8406ec
git push -f
Than use the edit feature above to change the merge target.

I'm addition we need you permission to distribute your changes along with Mixxx.
Please sign: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

And comment here when done.

@frankgrimy frankgrimy changed the base branch from main to 2.4 September 24, 2024 17:17
@frankgrimy frankgrimy changed the base branch from 2.4 to main September 24, 2024 17:17
Fixes Novation Launchpad X detection in macOS
@frankgrimy
Copy link
Contributor Author

Well, it seems ok now. I've also signed the form.

@daschuer
Copy link
Member

Cool. Thank you. I would like to add you to the contributor list in the Mixxx about box. Which name should I use?

@daschuer daschuer merged commit 9db85cf into mixxxdj:2.4 Sep 24, 2024
1 check passed
@frankgrimy
Copy link
Contributor Author

Just go with Frank Grimy

@Swiftb0y
Copy link
Member

I'm a little too late, but an alternative solution would be change the other heuristic code instead of stripping input and output, we should just strip in and out.

@daschuer
Copy link
Member

It is hard to predict property naming conventions anyway. I think a better solution would be to make this part of the mappings. Something like collecting this matching table from all found mapping files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants