Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent crash when no app windows have the focus #13657

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

acolombier
Copy link
Member

This crash occurs when using the GoToItem while a window is open in Mixxx (eg. settings) and was last to have focus, but the Mixxx application doesn't have the focus anymore

@acolombier acolombier force-pushed the fix/crash-windows-focus branch from 855c191 to 2951658 Compare September 15, 2024 15:36
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

src/library/librarycontrol.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Swiftb0y Swiftb0y merged commit 497121e into mixxxdj:2.5 Sep 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants