Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantization in the effect engine (metronome effect) #13636

Merged
merged 19 commits into from
Sep 15, 2024
Merged

Fix quantization in the effect engine (metronome effect) #13636

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
27baedd
Skip copy if source is equal the destination the copy is unnecessary …
daschuer Sep 1, 2024
77cdbac
Rename beat_fraction to beat_fraction_buffer_end to clarify that the …
daschuer Sep 1, 2024
92ffa72
Avoid unnecessary seconds round-trip in GroupFeatureState
daschuer Sep 2, 2024
22b7c29
Remove unused include
daschuer Sep 3, 2024
808c09c
GroupFeatureState: std::optional
daschuer Sep 3, 2024
c0cbd6a
Add scratch_rate to GroupFeatureState to allow to quantize effects du…
daschuer Sep 3, 2024
8454cce
Fix quantization with the metronome effect. It was one buffer off.
daschuer Sep 3, 2024
6c67cd8
Introduce m_actual_speed with is what the scalers actually did.
daschuer Sep 6, 2024
885e9ef
Don't snap "beat_next" and "beat_prev" to the nearest beat. This was …
daschuer Sep 6, 2024
8ea3457
Fix the metronome effect during scratching using scratch_rate.
daschuer Sep 6, 2024
c3f084d
Don't use std::optional::value introduced in macOS 10.13
daschuer Sep 9, 2024
e5ff7f3
default GroupFeatureState ctor
daschuer Sep 9, 2024
1fecf39
Improve readability in meronomeeffect.cpp
daschuer Sep 9, 2024
11af751
Fix use of GroupFeatureState in LoudnessContourEffect
daschuer Sep 9, 2024
9293b51
refactor: move metronome sampledata into separate translation unit
Swiftb0y Sep 11, 2024
5e74ec6
Fix metronome without a sync enabled
daschuer Sep 12, 2024
26d3029
Avoid to fade in the metronome effect, because this would mangle the …
daschuer Sep 13, 2024
2081952
Combine frames and scratch_rate into one optional because they are al…
daschuer Sep 13, 2024
f019874
refactor: use higher-level `std::span` based logic
Swiftb0y Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 44 additions & 37 deletions src/effects/backends/builtin/metronomeeffect.cpp
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes here are really hard to follow because they mix offset and timing calculations with buffer indexing (mixing levels of abstraction) and thus I'm neither confident about the reliability nor safety of the code...

Do you think its feasible to reorganize it a little so its easier to understand?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to fix that by calculate everything in frames. Maybe I was not too successful or comments are missing.
Can you give some hints what can be improved?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rework it a little and open a PR to your branch ASAP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look daschuer#97

Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ void MetronomeEffect::processChannel(
const GroupFeatureState& groupFeatures) {
Q_UNUSED(pInput);

Swiftb0y marked this conversation as resolved.
Show resolved Hide resolved
MetronomeGroupState* gs = pGroupState;

if (enableState == EffectEnableState::Disabled) {
gs->m_framesSinceClickStart = 0;
// assume click is fully played
return;
}

MetronomeGroupState* gs = pGroupState;

SINT clickSize = kClickSize44100;
const CSAMPLE* click = kClick44100;
if (engineParameters.sampleRate() >= 96000) {
Expand All @@ -76,53 +76,60 @@ void MetronomeEffect::processChannel(
click = kClick48000;
}

SINT maxFrames;
if (m_pSyncParameter->toBool() && groupFeatures.beat_length_frames.has_value()) {
maxFrames = static_cast<SINT>(groupFeatures.beat_length_frames.value());
if (groupFeatures.beat_fraction_buffer_end.has_value()) {
const auto currentFrame = static_cast<SINT>(
maxFrames * groupFeatures.beat_fraction_buffer_end.value());
if (maxFrames > clickSize &&
currentFrame > clickSize &&
currentFrame < maxFrames - clickSize &&
gs->m_framesSinceClickStart > clickSize) {
// plays a single click on low speed
gs->m_framesSinceClickStart = currentFrame;
}
}
} else {
maxFrames = static_cast<SINT>(
engineParameters.sampleRate() * 60 / m_pBpmParameter->value());
}

if (pOutput != pInput) {
SampleUtil::copy(pOutput, pInput, engineParameters.samplesPerBuffer());
}

if (enableState == EffectEnableState::Enabling) {
if (m_pSyncParameter->toBool() && groupFeatures.beat_fraction_buffer_end.has_value()) {
// Skip first click and sync phase
gs->m_framesSinceClickStart = clickSize;
} else {
// click right away after enabling
gs->m_framesSinceClickStart = 0;
}
}

if (gs->m_framesSinceClickStart < clickSize) {
// still in click region, write remaining click frames.
// In click region, write remaining click frames.
const SINT copyFrames =
math_min(engineParameters.framesPerBuffer(),
clickSize - gs->m_framesSinceClickStart);
SampleUtil::addMonoToStereo(pOutput, &click[gs->m_framesSinceClickStart], copyFrames);
}

gs->m_framesSinceClickStart += engineParameters.framesPerBuffer();
double bufferEnd = gs->m_framesSinceClickStart + engineParameters.framesPerBuffer();

if (gs->m_framesSinceClickStart > maxFrames) {
// overflow, all overflowed frames are the start of a new click sound
gs->m_framesSinceClickStart -= maxFrames;
while (gs->m_framesSinceClickStart > engineParameters.framesPerBuffer()) {
// loop into a valid region, this happens if the maxFrames was lowered
gs->m_framesSinceClickStart -= engineParameters.framesPerBuffer();
double nextClickStart = bufferEnd; // default to "no new click";
if (m_pSyncParameter->toBool() && groupFeatures.beat_length_frames.has_value()) {
if (groupFeatures.beat_fraction_buffer_end.has_value()) {
double beatToBufferEnd =
groupFeatures.beat_length_frames.value() *
groupFeatures.beat_fraction_buffer_end.value();
if (bufferEnd > beatToBufferEnd) {
// We have a new beat before the current buffer ends
nextClickStart = bufferEnd - beatToBufferEnd;
}
} else {
nextClickStart = groupFeatures.beat_length_frames.value();
}
} else {
nextClickStart = engineParameters.sampleRate() * 60 / m_pBpmParameter->value();
}

// gs->m_framesSinceClickStart matches now already at the first frame
// of next pOutput.
const unsigned int outputOffset =
engineParameters.framesPerBuffer() - gs->m_framesSinceClickStart;
const unsigned int copyFrames =
math_min(gs->m_framesSinceClickStart, clickSize);
SampleUtil::addMonoToStereo(&pOutput[outputOffset * 2], click, copyFrames);
if (bufferEnd > nextClickStart) {
// We need to start a new click
SINT outputOffset = static_cast<SINT>(nextClickStart) - gs->m_framesSinceClickStart;
if (outputOffset > 0) {
if (outputOffset < engineParameters.framesPerBuffer()) {
Swiftb0y marked this conversation as resolved.
Show resolved Hide resolved
const SINT copyFrames =
math_min(engineParameters.framesPerBuffer() - outputOffset, clickSize);
SampleUtil::addMonoToStereo(&pOutput[outputOffset * 2], &click[0], copyFrames);
gs->m_framesSinceClickStart = -outputOffset;
}
}
}
if (gs->m_framesSinceClickStart < engineParameters.framesPerBuffer() + clickSize) {
gs->m_framesSinceClickStart += engineParameters.framesPerBuffer();
}
}