Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reloop Beatmix 2/4 controller mapping #13605

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

sblaisot
Copy link
Member

Update controller mapping for Reloop Beatmix 2/4 for Mixxx 2.4

  • Replace hostcue_X_enabled with hotcue_X_status
  • Replace engine.connectControl with engine.makeConnection
  • Delay controller status request at startup to make it work again
  • Replace track_samples with track_loaded
  • Fix jogLed being lit on track unload

* Wiki/manual : http://www.mixxx.org/wiki/doku.php/reloop_beatmix_2
* Wiki/manual : http://www.mixxx.org/wiki/doku.php/reloop_beatmix_4
* support forum : http://mixxx.org/forums/viewtopic.php?f=7&t=8428
* Wiki/manual : https://github.com/mixxxdj/mixxx/wiki/reloop_beatmix_2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Wiki/manual : https://github.com/mixxxdj/mixxx/wiki/reloop_beatmix_2
* Wiki/manual : https://github.com/mixxxdj/mixxx/wiki/Reloop-Beatmix-2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this redundant to the manual link at the begining of the XML file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but, hey, this comes from 2016 🤷

@ronso0
Copy link
Member

ronso0 commented Aug 26, 2024

Thanks! There are some pre-commit issues. FYI print() can be replaced with console.log()
(just noticed this, not going to review the code)

@sblaisot sblaisot force-pushed the reloop_beatmix_4_quickfix branch from b572da0 to 8b01c6b Compare August 26, 2024 21:50
@sblaisot
Copy link
Member Author

Thanks! There are some pre-commit issues.

Thanks, pre-commit issues have been adressed

FYI print() can be replaced with console.log() (just noticed this, not going to review the code)

Ok, I changed all print() to console.log()

@sblaisot sblaisot force-pushed the reloop_beatmix_4_quickfix branch from 8b01c6b to 1d2e4b9 Compare August 26, 2024 21:56
@sblaisot
Copy link
Member Author

@Swiftb0y @ronso0 Can I merge this PR now ?

@Swiftb0y
Copy link
Member

yup, Sorry for forgetting about it.

@Swiftb0y Swiftb0y merged commit 414a8a5 into mixxxdj:2.4 Sep 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants