(fix) use 'played' track color also for played/play count delegate #13538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CheckboxDelegate base class, use it for BPMDelegate and play count delegate. This allows moving redundant paintItem() code to CheckboxDelegate, and thereby removing the PlayCountDelegate.
ronso0
force-pushed
the
played-delegate-color-fix
branch
from
d1cb360 to
4771726
Compare
|
Works as expected! |
|
Thank you! |
ronso0
added a commit
to ronso0/mixxx
that referenced
this pull request
Aug 8, 2024
ronso0
added a commit
to ronso0/mixxx
that referenced
this pull request
Aug 8, 2024
ronso0
added a commit
to ronso0/mixxx
that referenced
this pull request
Aug 8, 2024
ronso0
added a commit
to ronso0/mixxx
that referenced
this pull request
Aug 8, 2024
Swiftb0y
added a commit
that referenced
this pull request
Aug 12, 2024
(fix) pre-commit/qsscheck: add c++ ObjectNames set via variable in #13538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlayCountDelegatewas not picking up the 'played' track color like other delegate(s).(tick the played checkbox and its label color wouldn't change to grey)
This adds
CheckboxDelegatebase class (and removes now obsoletePlayCountDelegate).It's used for BPMDelegate and the play count delegate, which allows moving redundant paintItem() code to
CheckboxDelegate.