Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Library: show Properties action in Missing and Hidden #13426

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 1, 2024

The Properties dialog is helpful also in Hidden and Missing. You can quickly check stored metadata like album, bitrate etc. of removed tracks. Though the entire Metadata doesn't make much sense there IMO.

Previously, Capability::EditMetadata was used to show/hide the metadata menu, star rating (and cover art menu?), that's why I decided to separate that and add Capability::Properties only for the properties action.

Wdyt?

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 6268dba into mixxxdj:2.5 Jul 4, 2024
13 checks passed
@ronso0 ronso0 deleted the track-prop-in-hidden-and-missing branch July 4, 2024 08:02
@ronso0 ronso0 added this to the 2.5.0 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants