Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Sound config: fix UX when applying config with missing/busy devices #13312

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jun 1, 2024

Fixes one cause of #13238 leaking EQ shelf controls / stuck overview on track load.

The scenario:

  • start Mixxx without a previously configured sound I/O
  • get warning that previous sound device for Main is n/a

    Mixxx was unable to open all the configured sound devices.

  • click Reconfigure
  • (no selection for Main), click Okay (or Apply + Okay)
  • Mixxx proceeds (should actually throw the "No output devices" warning)

The issue:

There is a 'modified' flag in DlgPrefSound set on user changes, if false this will prevent re-applying the current config and the resulting sound pause when querying and re-setting the devices.
However, when the sound config is loaded in DlgPrefSound and devices are not found, the respective combobox will display 'None' even though that device is still set in the config. I.e. the visual state diverges from the config.
Clicking Apply would then not apply this new (visual) state since the 'modified' flag has not been set.

The fix:

Set the 'modified' flag if configured devices are not found.
Apply will then apply as desired.
(and, in case of missing Main output, Mixxx will throw the "No output devices" warning)

Leaking EQ shelf controls and stuck overview on track load is another story...

@ronso0 ronso0 changed the title Sound config: fix UX when applying config with missing/busy devices (fix) Sound config: fix UX when applying config with missing/busy devices Jun 8, 2024
@ronso0 ronso0 added this to the 2.5-beta milestone Jun 8, 2024
@ronso0
Copy link
Member Author

ronso0 commented Jun 8, 2024

Assigning this to 2.5-beta even though it's a 2.4 fix so we have it on the radar for the release.

@daschuer
Copy link
Member

daschuer commented Jun 9, 2024

We have the 2.4.2 milestone and will do the last 2.4 release short before the 2.5.0 release. So let's use the 2.4.2 milestone for that.

@daschuer daschuer modified the milestones: 2.5-beta, 2.4.2 Jun 9, 2024
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix and the good documentation.

@daschuer daschuer merged commit 3acd833 into mixxxdj:2.4 Jun 9, 2024
14 checks passed
@ronso0 ronso0 deleted the startup-no-sound-IO-fix branch June 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants