(fix) Sound config: fix UX when applying config with missing/busy devices #13312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one cause of #13238 leaking EQ shelf controls / stuck overview on track load.
The scenario:
The issue:
There is a 'modified' flag in DlgPrefSound set on user changes, if false this will prevent re-applying the current config and the resulting sound pause when querying and re-setting the devices.
However, when the sound config is loaded in DlgPrefSound and devices are not found, the respective combobox will display 'None' even though that device is still set in the config. I.e. the visual state diverges from the config.
Clicking Apply would then not apply this new (visual) state since the 'modified' flag has not been set.
The fix:
Set the 'modified' flag if configured devices are not found.
Apply will then apply as desired.
(and, in case of missing Main output, Mixxx will throw the "No output devices" warning)
Leaking EQ shelf controls and stuck overview on track load is another story...