Recording: with empty config, save default split size immediately #13304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
requested changes
May 30, 2024
There was a problem hiding this comment.
Thank you for the fix. Can you please also adjust this:
mixxx/src/recording/recordingmanager.cpp
Line 328 in 18a3e4a
A common class for all the recording defaults would be also nice but probably out of the scope of this bug-fix PR:
"preferences/replaygainsettings.cpp"
ronso0
force-pushed
the
rec-pref-split-size
branch
from
a885d7d to
6eb76bc
Compare
|
Oh, right. |
daschuer
reviewed
May 30, 2024
| //Use max RIFF size (4GB) as default index, since usually people don't want to split. | ||
| comboBoxSplitting->setCurrentIndex(4); | ||
| // Save the value immediately, otherwise RecordingManager would fall back |
There was a problem hiding this comment.
Yeah, well, I overlooked that we actually only need to use the same default in both unit.
Saving to the config doesn't hurt though.
and adjust the default in RecordingManager
ronso0
force-pushed
the
rec-pref-split-size
branch
from
6eb76bc to
68f27cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported in the forum
https://mixxx.discourse.group/t/recording-cut-into-parts/29631