Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub CI: Skip the manifest update job on forks #13278

Conversation

cr7pt0gr4ph7
Copy link
Contributor

The steps of manifest update job are already skipped on forks because they do not have the necessary secrets configured, so we skip the job altogether for any repository that is not the main mixxxdj/mixxx repository to avoid unnecessary noise in the build log (as well as some issues related to canceling build jobs).

It would be preferable to directly check for the presence of the secrets in jobs.<job_id>.if, but that is not possible, as per actions/runner#520.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. any objections?

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daschuer daschuer merged commit 3df1c88 into mixxxdj:main May 25, 2024
13 checks passed
@cr7pt0gr4ph7 cr7pt0gr4ph7 deleted the ready-for-merge/disable-netlify-build-for-forks branch October 4, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants