Novation Dicer: remove flanger mapping with quickeffect toggle #13196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
changed the title
|
The function is described here: https://djtechtools.com/2010/11/11/novation-dicer-mapping-for-traktor-scratch/ |
|
Also, if it's removed, why is it still an option? |
|
@Phr3d13 is this solution okay for you? @JoergAtGithub do you have time to review and merge this? |
JoergAtGithub
requested changes
May 13, 2024
|
whoops, embarrasing, see fixup |
Swiftb0y
force-pushed
the
fix/gh13134-novation-dicer-removed-flanger
branch
from
5f7f3d4 to
6a2df78
Compare
|
merge? |
|
Thank you! |
|
Thank you for the review ;) |
This doesn't remove the Flanger effect (why?), only the deprecated direct effect control from the time when Mixxx only had a handful of effects, and only for this particular mapping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13134
Tbh. this is just an idea. I don't know how much sense it makes. I would appreciate alternative suggestions.