Windows: Capitalized Start Menu folder and automatic version in LICENSE.rtf #13178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
Apr 28, 2024
| @@ -1,7 +1,7 @@ | |||
| {\rtf1\ansi\ansicpg1252\deff0\nouicompat{\fonttbl{\f0\fnil\fcharset0 Courier New;}} | |||
| {\colortbl ;\red0\green0\blue255;} | |||
| {\*\generator Riched20 10.0.14393}\viewkind4\uc1 | |||
| \pard\qj\ul\b\f0\fs22\lang1036 Mixxx version 2.4, Digital DJ'ing software.\ulnone\b0\fs24\par | |||
| \pard\qj\ul\b\f0\fs22\lang1036 Mixxx @CMAKE_PROJECT_VERSION@, Digital DJ'ing software.\ulnone\b0\fs24\par | |||
| \fs22 Copyright (C) 2001-2023 Mixxx Development Team\par | |||
There was a problem hiding this comment.
Should we have an automatic copyright year as well?
There was a problem hiding this comment.
While this is a good idea, I like to postpone the work for now. This is not trivial, because the LICENSE.rtf is configured at configure time, but I think we need the time from the HEAD commit which may change without reconfigure. On the other hand, I don't want to force reconfigure the build after every commit.
Swiftb0y
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have double checked that the changed spelling of Mixxx dos not break the update form an order installation.