fix: add missing spacer in interface preference #13094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
force-pushed
the
fix/missing-spacer-dlg
branch
from
490fba6 to
0aa24da
Compare
acolombier
force-pushed
the
fix/missing-spacer-dlg
branch
from
0aa24da to
962f70b
Compare
ronso0
reviewed
Apr 13, 2024
acolombier
force-pushed
the
fix/missing-spacer-dlg
branch
from
962f70b to
bf3e814
Compare
|
Strange, that still produces a bottom margin of ~20px. |
|
I didn't find a (quick) solution for the bottom padding, though I still wonder why it works in other dialogs. QtGui quirks... 🤷♂️ Thank you, LGTM! |
|
@ronso0 merge? |
|
Yes, sorry I got distracted and forgot to press the confirm button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: