Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: Always prefer OpenGL framework on macOS #13080

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Apr 10, 2024

This patch ensures that we always link the system-provided OpenGL on macOS to avoid accidentally picking the wrong implementation (e.g. X11 OpenGL if the user has XQuartz installed.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 7b8d709 into mixxxdj:2.4 Apr 10, 2024
14 checks passed
@fwcd fwcd deleted the prefer-opengl-framework-macos branch April 10, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants