Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components bug fixes #1303

Merged
merged 2 commits into from
Jul 6, 2017
Merged

Components bug fixes #1303

merged 2 commits into from
Jul 6, 2017

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jul 4, 2017

Fixing a few small bugs in the Components controller mapping library

Be-ing added 2 commits July 4, 2017 13:09
@Be-ing
Components: fix soft takeover with shift + effect knob
327f70c 
to select different effects
@Be-ing
Components: always stop long press Button timers on release
46adf1c 
I did not figure out how to reproduce this reliably, but somehow it was
possible to get into a state where short presses were acting like long
presses.
@daschuer
Copy link
Member

daschuer commented Jul 6, 2017

Thank you! LGTM

@daschuer daschuer merged commit 8eb43d3 into mixxxdj:master Jul 6, 2017
@Be-ing Be-ing deleted the components_effects_bugfixes branch November 14, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @daschuer