fix: allow missing COs on QML component #13011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Have you considered to you make this depend on a boolean Q_PROPERTY that is off by default? So that we need to be explicit about it that you 2ant that behavior? Or, if that is too strict, maybe we could check if the |
|
To elaborate, I'd just like to preserve the debug assertion when doing QML skin development if possible.🤔 |
Yes, I was thinking the same if we wanted to keep the asserting. Will update that! |
acolombier
force-pushed
the
fix/allow-mission-co
branch
from
83ee3ba to
86067f9
Compare
6 tasks
|
@Holzhaus are you happy with the look of this fix now? |
Holzhaus
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
Mixxx.ControlProxyto reference CO that don't exist without crashing. This is to ensure backward compatibility the controller JS engine which allows to connect to in-existing COs and let the caller handle invalid (seesrc/controllers/scripting/legacy/controllerscriptinterfacelegacy.cpp/ControllerScriptInterfaceLegacy::makeConnectionInternal.This is a dependency for #11407